Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Croatian translation for 0dyseus@CinnamonMaximusFork, 0dyseus@Cinnamo… #17

Closed
wants to merge 1 commit into from

Conversation

muzena
Copy link
Contributor

@muzena muzena commented Feb 27, 2017

…nTweaks, 0dyseus@WindowDemandsAttentionBehavior, AppSwitcher@entelechy, transparent-panels@germanfr

…nTweaks, 0dyseus@WindowDemandsAttentionBehavior, AppSwitcher@entelechy, transparent-panels@germanfr
@NikoKrause
Copy link
Member

@Odyseus @germanfr
I think you're happy with this new translations?

@germanfr
Copy link
Contributor

No, please submit a PR to my repository instead. I don't do the development here. There may be incompatibilities with the latest version, which is not here. This is just a distribution channel.

@NikoKrause
Copy link
Member

There can't be incompatibilities with translation files. The only thing that can happen is, that new translatable Strings are not translated.

@Odyseus
Copy link
Contributor

Odyseus commented Feb 28, 2017

@NikoKrause

I think you're happy with this new translations?

No, I'm not!

Am I the only one that can see the screw up in this PR and in this one? All the xlets' history is mixed with unrelated changes from a lot a other xlets, for one!

It shouldn't matter the amount of PRs, but the amount of commits. One commit per xlet!

You shouldn't have pushed this PR without the consent of every single author.

And this...

If one of the authors of these applets has a problem with the translation, he can create a PR, which deletes the file.

...isn't a solution. Because before deleting and creating PRs, I would have to synchronize every single branch I have (7 applets equals about 21 freaking commands minimum!).

I'm going to join @germanfr's decision and reject this PR. And I state for the record, I will reject all future PRs to any of my xlets without exceptions.

@muzena
Copy link
Contributor Author

muzena commented Feb 28, 2017

@Odyseus @germanfr
I ask @NikoKrause here to add PR for multiple po files or each aplet separate.

@muzena
Copy link
Contributor Author

muzena commented Feb 28, 2017

@Odyseus
Where do I submit PR for Cinnamon Maximus, Cinnamon Tweaks, Window demands attention behavior, here on in your repository?

@muzena muzena closed this Mar 3, 2017
@collinss
Copy link
Member

collinss commented Mar 3, 2017

I agree that we should NEVER have more than one applet effected by a single commit, NO MATTER WHAT. Unlike most repositories where the history is looked at as a whole, here it is much more common to look at the history of a single xlet at a time. Any changes that effect a different xlet will just make things harder to follow.

@NikoKrause For applets, etc. that are actively maintained, I think we should wait for author approval even for things like translations. Not because I think any applet developer would refuse to allow their applet to be translated, but because it is still their project, and their workflow, and they are the ones that are going to care the most about the git history, etc.

@NikoKrause
Copy link
Member

Yeah. You are right with the 1 applet - 1 commit. Have not thought that through. Sorry for that.

@Odyseus
muzena wanted to know, where to contribute the translations for your extensions.
Do you prefer pull requests here https://github.com/Odyseus/CinnamonTools
?

@Odyseus
Copy link
Contributor

Odyseus commented Mar 5, 2017

@NikoKrause: All my xlet's READMEs provide that information.

@muzena
Copy link
Contributor Author

muzena commented Mar 5, 2017

@NikoKrause
If it possible, I think the best it would be to make translation system for applets/desklets/extensions like you made in launchpad for cinnviistarkmenu

@NikoKrause
Copy link
Member

I already thought of that as well. It's not a big deal to set something like this up. The templates (and/or translations) would be imported automatically to launchpad from this github repository. Every developer could export/download the translations from launchpad and import it manually to his applet, if he wanted to. So nobody would be forced to use it, if he doesn't want to, and still could use other ways to provide translations for his applet.

Unfortunatelly I'm pretty sure you'll find some devs, who would protest against that.

Also the decision is not up to me, but to clefebvre.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants