-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Croatian translation for 0dyseus@CinnamonMaximusFork, 0dyseus@Cinnamo… #17
Conversation
…nTweaks, 0dyseus@WindowDemandsAttentionBehavior, AppSwitcher@entelechy, transparent-panels@germanfr
No, please submit a PR to my repository instead. I don't do the development here. There may be incompatibilities with the latest version, which is not here. This is just a distribution channel. |
There can't be incompatibilities with translation files. The only thing that can happen is, that new translatable Strings are not translated. |
No, I'm not! Am I the only one that can see the screw up in this PR and in this one? All the xlets' history is mixed with unrelated changes from a lot a other xlets, for one! It shouldn't matter the amount of PRs, but the amount of commits. One commit per xlet! You shouldn't have pushed this PR without the consent of every single author. And this...
...isn't a solution. Because before deleting and creating PRs, I would have to synchronize every single branch I have (7 applets equals about 21 freaking commands minimum!). I'm going to join @germanfr's decision and reject this PR. And I state for the record, I will reject all future PRs to any of my xlets without exceptions. |
@Odyseus @germanfr |
@Odyseus |
I agree that we should NEVER have more than one applet effected by a single commit, NO MATTER WHAT. Unlike most repositories where the history is looked at as a whole, here it is much more common to look at the history of a single xlet at a time. Any changes that effect a different xlet will just make things harder to follow. @NikoKrause For applets, etc. that are actively maintained, I think we should wait for author approval even for things like translations. Not because I think any applet developer would refuse to allow their applet to be translated, but because it is still their project, and their workflow, and they are the ones that are going to care the most about the git history, etc. |
Yeah. You are right with the 1 applet - 1 commit. Have not thought that through. Sorry for that. @Odyseus |
@NikoKrause: All my xlet's READMEs provide that information. |
@NikoKrause |
I already thought of that as well. It's not a big deal to set something like this up. The templates (and/or translations) would be imported automatically to launchpad from this github repository. Every developer could export/download the translations from launchpad and import it manually to his applet, if he wanted to. So nobody would be forced to use it, if he doesn't want to, and still could use other ways to provide translations for his applet. Unfortunatelly I'm pretty sure you'll find some devs, who would protest against that. Also the decision is not up to me, but to clefebvre. |
…nTweaks, 0dyseus@WindowDemandsAttentionBehavior, AppSwitcher@entelechy, transparent-panels@germanfr