Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new theme: Warthog #544

Merged
merged 36 commits into from
Jan 11, 2019
Merged

Add new theme: Warthog #544

merged 36 commits into from
Jan 11, 2019

Conversation

Radek71
Copy link
Contributor

@Radek71 Radek71 commented Jan 10, 2019

@brownsr

hopefully this is the right way how to add new theme...I have not much experiences with github from the past. I followed the instructions Git basics from the cinnamon-spices repository.

@brownsr
Copy link
Member

brownsr commented Jan 11, 2019

There was a spurious small change to Thunderbolt css which I could simply delete. Could do with a reference to the license in the info. There will be quite a bit of follow up work to consider : grouped window list icons in a vertical panel, a lot of commented out code, the popup menus are still jumpy, and for some reason I found that it seemed to make my system run very slow. That last in particular wants investigating, and I can't give you any guidelines as to what it might be, other than there were messages about missing gradient start and end in the .xsession-errors file. That's a problem some other themes have, so I would look for a bit of missing CSS in comparison with known good themes.

Regards

Simon

@brownsr brownsr merged commit 204aec1 into linuxmint:master Jan 11, 2019
brownsr added a commit to brownsr/cinnamon-spices-themes that referenced this pull request Jan 11, 2019
brownsr added a commit that referenced this pull request Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants