g_setenv/g_unsetenv around meta_init discards some user defined environment variables

[flo-at]

Distribution

Arch

Package version

5.6.8

Graphics hardware in use

No response

Frequency

Always

Bug description

It's not possible to globally define NO_AT_BRIDGE, NO_GAIL (and probably some others) so that applications started inside Cinnamon will have them set as intended.

The reason is the combination or g_setenv / g_unsetenv around meta_init. The correct behaviour would be to save the old values of the affected variables and restore them instead of unsetting the variable.

Steps to reproduce

Try to set NO_AT_BRIDGE=1 in /etc/environment, /etc/profile, ~/.xprofile or any of these and start cinnamon. It will be unset because of the bug and not affect the child processes as intended.

Expected behavior

It should be possible to globally set the affected variables to whatever value the user wants them to be.

Additional information

This is one of the lines that need to be changed:

cinnamon/src/main.c

Line 342 in ec10d06

g_unsetenv ("NO_AT_BRIDGE");

[flo-at]

If I get some feedback on this, I'd create a PR.

[mtwebster]

This should be fine I think