[Code cleanup] [1.8] Don't use deprecated "reparent" function #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I looks like more code is needed to do the same thing as before. Regression potential: high. If we really need to do something like this, I suggest we introduce a function somewhere ("clutterUtils.js"?) that does the same thing, so that all occurrences can be changed with minimal impact. |
|
@autarkper Sounds like a good idea, especially for Clutter, which is known to break API with moving towards 2.0. Maybe this could even be done in C (with JS-bindings), so that all the St stuff (which uses Clutter) can use it as well. |
|
This pull can't be automatically merged anymore. It probably conflicts with #1211. |
|
I would still prefer a utility function as replacement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.