Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. Cleanup and upgrades #1747

Closed
wants to merge 12 commits into from
Closed

Misc. Cleanup and upgrades #1747

wants to merge 12 commits into from

Conversation

Lusito
Copy link
Contributor

@Lusito Lusito commented Feb 26, 2013

  • Removing unused panelmenu.js
  • Adding alternative to the deprecated reparent method (see [Code cleanup] [1.8] Don't use deprecated "reparent" function #1131).
    • usage: global.reparentActor(actor, parent);
    • parent can be null.
    • does not care if actor already is a child of parent, so it can be removed and appended to the end by doing global.reparentActor(actor, actor.get_parent()).
  • Refactoring log initialization out of the start method.
  • Removed duplicate code snippet in dnd.js
  • Error log cleanup, removes a lot of unnecessary output and fixes a bug with out of date extensions.
  • get_num_instances_for_xlet moved to extension.js and renamed to get_max_instances

@Lusito
Copy link
Contributor Author

Lusito commented Apr 18, 2013

@clefebvre: Can we get this into 1.8 ?
I guess I could make them separate pull requests if needed.

@clefebvre
Copy link
Member

We can try, let's talk about it on the IRC.. or in the meeting if we don't meet before then.

@Lusito
Copy link
Contributor Author

Lusito commented Apr 23, 2013

will be merged in separate pulls

@Lusito Lusito closed this Apr 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants