melange/all: huge style refactor #8447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzexor
force-pushed
the
melange-pylint-cleanup
branch
from
ebcc2c2
to
7fdbd23
Compare
itzexor
force-pushed
the
melange-pylint-cleanup
branch
from
7fdbd23
to
3eb6454
Compare
pylintrc: - add `unused-argument` and `wrong-import-posistion` to ignored warnings since we trigger these often with gi callback signatures and the way we have to specify library versions before import via a function call. - ignore some common size/width vars from naming restrictions - allow loading some common modules so that we get less undefined references melange: - convert everything except dbus methods to snake_case - various other style cleanups here and there - remove unused memory page, as this is no longer supported by cjs and I haven't seen any replacement functionality.
itzexor
force-pushed
the
melange-pylint-cleanup
branch
from
3eb6454
to
68c0dbd
Compare
itzexor
changed the title
clefebvre
pushed a commit
that referenced
this pull request
Jun 5, 2019
pylintrc: - add `unused-argument` and `wrong-import-posistion` to ignored warnings since we trigger these often with gi callback signatures and the way we have to specify library versions before import via a function call. - ignore some common size/width vars from naming restrictions - allow loading some common modules so that we get less undefined references melange: - convert everything except dbus methods to snake_case - various other style cleanups here and there - remove unused memory page, as this is no longer supported by cjs and I haven't seen any replacement functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about as good as I can get it. It makes pylint warnings at least somewhat usable, from ~400 warnings to like 60 or less....
pylintrc:
we trigger these often with gi callback signatures and the way we have
to specify gi lib versions before import via a function call.
melange:
and i haven't seen any replacement functionality.