[WIP] window.c: Don't ever send ConfigureNotifies for OR windows #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed with gtk 3.20 for correct placement when the OR is moved between hiding/showing, otherwise the behavior described in the mutter commit occurs every time. From mutter commit: GNOME/mutter@e362227
itzexor
changed the title
|
This isn't quite ready yet, there are other code paths that call send_configure_notify on OR windows and cause the assertion to fail. I believe that this commit needs to be implemented as well: GNOME/mutter@729fb2e Edit: Wrong commit, that was already in the codebase. The problem was with the fix for linuxmint/cinnamon#681. Reverting it seems like the best course of action as the window manager is not supposed to move OR windows, but I'm not sure if it will reintroduce the firefox tooltip issue... I'm going to hold off on this until I can discuss it with you all. |
This reverts commit 9bda8d2.
|
@leigh123linux @Cobinja If either of you have any insights into this, please let me know. Thanks in advance. |
|
Closing in favor of #230 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the duplicate pull request/emaIl spam. I missed a bracket and squashed the fix commit.
This is needed with gtk 3.20 for correct placement when the
OR is moved between hiding/showing, otherwise the behavior
described in the mutter commit occurs every time.
From mutter commit:
GNOME/mutter@e362227
Fixes #224
Fixes linuxmint/cinnamon#5202
Fixes linuxmint/cinnamon#5195