Unredirect fixes #250
Merged
Unredirect fixes #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damage coordinates are relative to the drawable not to the screen. So we have to check whether x and y are 0 and not window_rect.x/y otherwise the herustic will never trigger for windows on monitors whos x and y are not 0. https://git.gnome.org/browse/mutter/commit/?id=cd32e4a
According to the documentation, the method returns "whether the X window that the actor was displaying has been destroyed" - that is very much true when we delay the actual actor destruction for a destroy animation, so update the method accordingly. https://git.gnome.org/browse/mutter/commit/?id=d50f8af
WindowActors can outlive their corresponding window to animate unmap. Unredirecting the actor does not make sense in that case, so make sure to not request it. https://git.gnome.org/browse/mutter/commit/?id=6e25c37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
837aeb1 fixes windows not being unredirected by the heuristic when located on a monitor that is not located at 0,0 in the screen.
The other 3 commits fix some misbehavior and a crash introduced with e5460a3
More info on the crash here:
https://bugzilla.gnome.org/show_bug.cgi?id=740133
https://bugzilla.redhat.com/show_bug.cgi?id=1149409
Edit: The application I reproduced the crash with locally was Universe Sandbox ²
Fixes #249