Clutter master clock improvements #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clefebvre
changed the title
This is an improvement for higher refresh rate monitors, though also seeing an improvement at 59.97-60Hz. Adapted from https://gitlab.gnome.org/vanvugt/mutter/commit/f17de523482fe10f8a6194f32782086e39976688 https://gitlab.gnome.org/GNOME/mutter/merge_requests/346
We are not using any multi-threaded implementation of Clutter, so it doesn't make sense to acquire a lock in this performance critical area.
jaszhix
changed the title
… with CLUTTER_ENABLE_DEBUG
clefebvre
changed the title
itzexor
added a commit
to itzexor/muffin
that referenced
this pull request
Aug 2, 2019
This reverts commit 00ccde6.
itzexor
added a commit
to itzexor/muffin
that referenced
this pull request
May 20, 2020
This reverts commit 00ccde6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement for higher refresh rate monitors, though seeing a noticeable reduction of input latency at 59.97-60Hz. Not seeing any change in Muffin's CPU usage. Tested on Nvidia and Mesa.
Note, the diff from upstream is a bit different because we preserve the ability to make the sync method configurable in #355.
Adapted from
https://gitlab.gnome.org/vanvugt/mutter/commit/f17de523482fe10f8a6194f32782086e39976688
https://gitlab.gnome.org/GNOME/mutter/merge_requests/346