Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cogl-pipeline-layer-private.h: remove a redundant redeclaration #468

Closed
wants to merge 1 commit into from

Conversation

brownsr
Copy link
Member

@brownsr brownsr commented Apr 8, 2019

and lose 800 lines of build spam

@jaszhix
Copy link
Contributor

jaszhix commented Apr 10, 2019

Can you please clarify where this build spam is coming from? If it is originating from muffin (in src/), we should fix the issues there. It's difficult to maintain a diverging code base this large, so I don't think we should touch these unless we absolutely have to. These changes may look simple to us, but on a low level, GCC optimizations can change from small details like this.

@collinss
Copy link
Member

I don't think this can be 'fixed' in muffin itself without removing the imports themselves, and even that wouldn't truly be a fix. However, if you removed -Wredundant-decls from the compiler flags for muffin, it would silence the warnings at least. The reason these warnings don't show up when compiling cogl is that that flag isn't supplied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants