Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary scrollbars on right-click menu #2118

Closed
dglava opened this issue Apr 13, 2019 · 9 comments
Closed

Unnecessary scrollbars on right-click menu #2118

dglava opened this issue Apr 13, 2019 · 9 comments
Assignees

Comments

@dglava
Copy link

dglava commented Apr 13, 2019

 * Nemo versionn 4.0.6
 * Is issue with desktop or windowed nemo? Windowed?
 * Distribution: Arch
 * Graphics hardware *and* driver used: Intel Ironlake GPU with the xf86-video-intel driver.
 * 32 or 64 bit: 64

Issue
The right-click menus have scrollbars when they can easily expand on the screen, for example the right-click menu on Trash.

Steps to reproduce
See video:
https://webmshare.com/gVjyv

Expected behaviour
There shouldn't be scrollbars and it should be expanded from the start.

@leigh123linux
Copy link
Contributor

@FrogMcRibbit
Copy link

XFCE devs had to face a similar issue with Thunar, or at least an issue caused by regressions in GTK3 too. Even if the regression is caused by changes in GTK3, they ended up patching Thunar to make it work as intended with GTK3 3.24.7+.

https://bugzilla.xfce.org/show_bug.cgi?id=15200

Linux Mint devs might have to do the same thing: patching Nemo even if it they didn't do anything wrong with Nemo so far.

@andreldm
Copy link

@FrogMcRibbit what was fixed in Thunar is a different issue, the submenu for templates was broken because its items were loaded asynchronously, which worked very well until GTK 3.24.5. I didn't have the time to prepare a reproducer sample to report it upstream, so I decided to drop the async load.
I wasn't super clear at https://bugzilla.xfce.org/show_bug.cgi?id=15200#c21, people also noticed the unnecessary scrollbars on context menu, that's what I meant when I said Nemo is also affected.

@malio10AC
Copy link

I have this issue, too. But only in places view and not in list view or tree view. And if I right click a place several times then the context menu for that place is displayed correctly.
System: Arch Linux 64bit with openbox, compton

@salif
Copy link

salif commented May 18, 2019

I have same issue

@dikonov
Copy link

dikonov commented May 22, 2019

Please, fix the bloody menus in any way possible!
This is the MOST annoying bug in Cinnamon and it that makes me sorely regret that I have updated Cinnamon and GTK.

@mtwebster
Copy link
Member

Can you guys confirm that if you select the sidebar item first (left click) then right-click, the menu displays properly. It should also be correct if using the keyboard menu button (not all keyboards have anymore).

Thanks

@malio10AC
Copy link

Yes, after a left click (on that item) the right click menu works properly.

@bashfulrobot
Copy link

I'm here to add a +1 on this. I'm not sure if this is helpful, but I converted a screen recording to a GIF to show the behaviour.

screen

$ nemo --version
nemo 4.0.6

$ cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=19.04
DISTRIB_CODENAME=disco
DISTRIB_DESCRIPTION="Ubuntu 19.04"

$ dpkg -l libgtk-3-0
<snip>
ii  libgtk-3-0:amd64 3.24.8-1ubuntu1 amd64        GTK+ graphical user interface library

If any additional info would be helpful - do not hesitate to reach out.

mtwebster added a commit to mtwebster/nemo that referenced this issue Jun 2, 2019
leigh123linux added a commit to leigh123linux/nemo that referenced this issue Jun 4, 2019
mtwebster added a commit to mtwebster/nemo that referenced this issue Jun 18, 2019
…right-

clicking on a currently-unselected item.

This reverts the behavior introduced in gtk 3.24.8:
https://gitlab.gnome.org/GNOME/gtk/commit/57300b49602b856b53f5d30ab3174591c0fb2845

By connecting our own handler to 'moved-to-rect' and performing the 'popped-up'
emission ourselves (and at the same time, preventing GtkMenu's own handler from
running), we avoid the fixate call which seems to be causing this.

Fixes linuxmint#2118
Fixes linuxmint#2153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants