Nemo Patched ! #3
Conversation
… name, prevents weird issues like seeing /home/Home/Desktop not /home/ikey/Desktop
… ever encountered. Changed it to system-file-manager instead.
|
Hi Ikey, Great to join forces and with very similar ideas. With Gnome going crazy I think we're indeed chasing the same ball here. We're talking to glebihan right now and seeing if we can revert his changes (entry bar basically) and merging yours. Give me a few days for it to happen (you're hitting us right in the middle of August here!!) :) |
|
I was kinda curious about that commit tbh :) |
|
Don't lose time, I've already made the changes to revert my previous commits. |
|
Thanks |
Also, don't unescape uris, they work fine, quoted or unquoted. https://bugs.launchpad.net/linuxmint/+bug/1330225
ghost
mentioned this pull request
ghost
mentioned this pull request
ghost
mentioned this pull request
With some GIO backends (observed at least with sftp),
g_file_info_get_symlink_target() returns an empty string rather
than NULL for non-symlinks. A warning and then segfault result:
** (nemo:8386): WARNING **: 18:34:22.807: File has symlink target, but is not marked as symlink
Thread 1 "nemo" received signal SIGSEGV, Segmentation fault.
0x00007ffff71beac0 in g_str_hash () from /usr/lib/libglib-2.0.so.0
(gdb) bt
#0 0x00007ffff71beac0 in g_str_hash () at /usr/lib/libglib-2.0.so.0
#1 0x00007ffff71bfa2f in g_hash_table_lookup_extended () at /usr/lib/libglib-2.0.so.0
#2 0x000055555564926e in modify_link_hash_table at ../libnemo-private/nemo-file.c:600
#3 0x000055555564ed11 in add_to_link_hash_table at ../libnemo-private/nemo-file.c:642
#4 update_info_internal at ../libnemo-private/nemo-file.c:2683
#5 0x000055555564f767 in nemo_file_update_info at ../libnemo-private/nemo-file.c:2702
#6 0x00005555556263ec in query_info_callback at ../libnemo-private/nemo-directory-async.c:3230
Defend against this at two levels:
- For non-symlinks, don't call g_file_info_get_symlink_target().
- Use g_return_if_fail() to prevent NULL pointer dereference.
Howdy do Gentlemen :)
As per: https://plus.google.com/105704906416776356848/posts/L1FnY1gc365
I want you guys to use my changes. Its the only way to keep them alive properly instead of rebasing on 3.6 etc. We're chasing the same ball so I figured we may as well be working from the same base.
I've made a point of publically telling people I pushed my patches against Nemo.
Cooperation! :) Serious don't be tied by my patches, extend, modify :)
Hope you use, happy to take suggestions and modify as per your requests ^^