Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

settings: Read config "onscreen-keyboard" #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jakko3
Copy link
Contributor

@Jakko3 Jakko3 commented Dec 21, 2023

The config option "onscreen-keyboard" takes no effect because it doesn't get read out. Add the missing read-out.

Fixes: #219

The config option "onscreen-keyboard" takes no effect because it doesn't
get read out. Add the missing read-out.
@mtwebster
Copy link
Member

I still don't think this is necessary - once I enable the keyboard via the accessibility menu, it stays enabled for me even across reboots -

When the menu item is toggled, the gsettings value is updated.

This never gets overridden by any other settings (because it isn't part of the bool_keys).

Please check again on your end, whether or not this setting resets at a reboot. I'm not against a visible setting if necessary, but if the menu item selection is persistent, it seems the most consistent (none of the other accessibility menu options are individually configurable either).

@clefebvre
Copy link
Member

I like the way it works for users right now. The readme could be clearer though for distros trying to overwrite the default.

@Jakko3
Copy link
Contributor Author

Jakko3 commented Jun 9, 2024

The gsettings set by user "lightdm" are currently not persistent over reboots in postmarketOS (based on Alpine Linux). Might be a permission issue in Alpine Linux. See comment #219 (comment).

If the accessibility checkbox for the onscreen keyboard is considered to be sufficient, the non-working slick-greeter setting "onscreen-keyboard" needs to be removed (from readme, manpage, gschema, etc.). Btw. the rather new setting "onscreen-keyboard-layout" is missing in readme and manpage.

I still would advertise for making the setting "onscreen-keyboard" work in the config file and additionally add it to lightdm-settings, as proposed in linuxmint/lightdm-settings#62. My intension is not about accessibility, it's about improving the handling for touch devices, which get used more and more also in classic Linux environments. Of course the choice is yours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting "onscreen-keyboard=true" doesn't get applied
3 participants