-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Trianglify background option to the 2.x branch #1158
Conversation
I think you need to update the test as well: https://github.com/linuxserver/Heimdall/blob/2.x/tests/Feature/SettingsTest.php It's currently expecting to see "Homepage Search" after "Background Image" |
I tried that but if you look at the output from the test, "Trianglify Random Seed" shows up twice, once under the appearance section and then again after homepage search. But if you look at the screenshot from the webbrowser it only shows up once. |
I think 6 is already in use for the default search provider, use 12 and 13 |
I changed it to 12 and 13 and the test still fails, the weird thing is that even though the text label talks about Trianglify, the link had setting 4 in it: |
Figured it out, it was a copy-paste issue on my end. ps. Glad you added the tests, they caught my mistake.. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@ullbergm we are just 10 days shy of the 5th anniversary of your initial PR, so thanks for persevering so we could finally get it in :D |
This will give you the option to use Trianglify instead of a background picture for some random background art.
Updated for the 2.x branch.