New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please update sqlite to 3.31.1. #108
Comments
Thanks for opening your first issue here! Be sure to follow the issue template! |
Expected BehaviorWhen a book is deleted using the web UI, it should be deleted from both the disk and the calibre databse. Current BehaviorThe book is only deleted from disk. It persists in the database and will continue to display on the web UI. Steps to Reproduce
Identified FixUpdate SQLite to 3.31.1 (or update Ubuntu to 20.04)/ EnvironmentOS: N/A Command used to create docker container (run/create/compose/screenshot)version: "3.0"
services:
calibre-web:
image: ghcr.io/linuxserver/calibre-web
container_name: calibre-web
environment:
- TZ=Europe/London
- DOCKER_MODS=linuxserver/calibre-web:calibre
volumes:
- /opt/config:/config
- /opt/books:/books
ports:
- 8083:8083 |
I am also experiencing this issue. Hopefully it's a quick fix for someone who's more familiar with this repository! |
As far as I can see we are not installing sqlite at all. Which version does calibre-web say we have installed? The reason we haven't moved to focal is that there was a bug in libseccomp that made images useless for arm users. The fix either has to be installed manually or enabling backports. |
From one of the calibre-web maintainers: janeczku/calibre-web#1639 (comment)
|
Not sure when we are going to rebase to ubuntu focal, so we probably need to do the dirty fix until then. |
Something like this should work for x86_64. I don't have any arm dev environment to test the fix on any other archs. echo "**** install updated SQLite driver ****" && \
pip3 install --no-cache-dir -U pysqlite3-binary && \
ln -s /usr/local/lib/python3.6/dist-packages/pysqlite3-binary/_sqlite3.cpython-36m-x86_64-linux-gnu.so /app/calibre-web/_sqlite3.so && \ |
you would need to install pip3 first; we only have it in there to install the requirements.txt stuff, then it's purged. Much like @tobbenb mentioned though, i don't see anywhere where we are adding pysqlite, sqlite, or anything similar outside of sqlalchemy to the image. |
The SQLite3 driver is packaged into Ubuntu by default. The version in 18.04 is not compatible with features used by one of the tables in the latest version of calibre-web. Updating to 20.04 fixes this. Although, as @tobbenb mentioned, Focal doesn't seem to be high on your list of priorities. Whilst I appreciate the following manifests are for the live versions rather than the bootstrapped versions, they should demonstrate that SQLite3 is installed by default and explain the mismatched versions.
The workaround proposed by calibre-web's maintainer, whilst dirty, solves this problem in the short term. |
Focal has issues when run on certain hardware due to upstream bugs, which is why we want to hold the upgrade, if we can. |
I understand. Hopefully we can incorporate the maintainer's suggested fix until those bugs are squashed. |
@jackhadrill Thanks for the input, fwiw I've only just picked this up and tried your fix.
I'll try and take a bit more of a look at this tonight. |
This fixes linuxserver#108
Hey @CHBMB, I created #111 to fix this issue. I choosed @jackhadrill's approach. I hope the PR is in line with the contribution guidelines. 🙂 |
Can't be merged to master until upstream push a new release. See [here](janeczku/calibre-web#1755) Will fix [this](#108) and also will close pending PR [here](#111)
I delete book error. janeczku/calibre-web#1639, please update sqlite to 3.31.1 to resolve it.
The text was updated successfully, but these errors were encountered: