Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install updated SQLite driver #111

Closed
wants to merge 1 commit into from
Closed

Install updated SQLite driver #111

wants to merge 1 commit into from

Conversation

Rabattkarte
Copy link

closes #108

linuxserver.io

  • [ x ] I have read the contributing guideline and understand that I have made the correct modifications

Description:

I install pysqlite3-binary via pip and symlink the shared object (.so) to the app directory as suggested by upstream dev.

Benefits of this PR and context:

This fixes #108 by installing pysqlite3-binary via pip. Deletion of books does work again.

How Has This Been Tested?

I built containers and tested:

  • Adding a book
  • Updating metadata
  • Deleting a book
  • Checking the SQLite version in /stats to be >= 3.31.1

Source / References:

@project-bot project-bot bot added this to PRs & in progress issues in Issue & PR Tracker Dec 18, 2020
github-actions[bot]
github-actions bot reviewed Dec 18, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@Rabattkarte Rabattkarte mentioned this pull request Dec 18, 2020
Closed
aptalca
aptalca reviewed Dec 18, 2020
View reviewed changes
Dockerfile
pip3 install --no-cache-dir -U \
pysqlite3-binary && \
ln -fs \
$(find /usr/local/lib/python3.6/dist-packages/pysqlite3/_sqlite3.*.so) \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When python gets updated to 3.7, this will break

@aptalca
Copy link
Member

aptalca commented Dec 21, 2020

It's failing on arm32

@Rabattkarte
Copy link
Author

It's failing on arm32

Yep, I accidentally triggered the build again. I need to look into how to test this locally, I'm a little bit confused by the CONTRIBUTION instructions here.

I will look into this later.

@CHBMB
Copy link
Member

CHBMB commented Jan 14, 2021

I've managed to build this on a focal base now which should sort out any of the sqlite issues. I'm just waiting for some upstream stuff to happen before I can open a PR.

CHBMB added a commit that referenced this pull request Jan 14, 2021
@CHBMB
Update to focal.
63478b8 
Can't be merged to master until upstream push a new release.  See [here](janeczku/calibre-web#1755)

Will fix [this](#108) and also will close pending PR [here](#111)
@CHBMB CHBMB mentioned this pull request Jan 14, 2021
Merged
@CHBMB CHBMB closed this Jan 17, 2021
Issue & PR Tracker automation moved this from PRs & in progress issues to Done Jan 17, 2021
@CHBMB
Copy link
Member

CHBMB commented Jan 17, 2021

@Rabattkarte Thanks for the PR, appreciate the input, but I've gone a different direction in tackling the issue. Hope that's ok. BTW armhf gave me some issues too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aptalca aptalca aptalca left review comments

@github-actions github-actions[bot] github-actions left review comments

Assignees
No one assigned
Labels
None yet
Projects
Issue & PR Tracker
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please update sqlite to 3.31.1.
3 participants
@Rabattkarte @aptalca @CHBMB