Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure hardware acceleration devices have proper group permissions #112

Closed
wants to merge 1 commit into from
Closed

Conversation

metronidazole
Copy link

linuxserver.io


  • I have read the contributing guideline and understand that I have made the correct modifications

Description:

This fixes issue #111 (and probably a lot of cases of #26 ) by ensuring all detected hardware acceleration devices have group permissions set (g+rwx). This is required for hardware acceleration to work if the docker host system does not have any group permissions set for them (these get replicated into the docker container)

Benefits of this PR and context:

Fixes hardware acceleration for many users, including those with synology devices which by default don't have group permissions set for the intel quicksync device (/dev/dri/renderD128)

How Has This Been Tested?

Yes - single line of code.

Source / References:

See #111

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this pull request! Be sure to follow the pull request template!

@aptalca
Copy link
Member

aptalca commented Jun 23, 2021

I don't believe you can change device permissions from inside the container unless it's running with --privileged

@metronidazole
Copy link
Author

I don't believe you can change device permissions from inside the container unless it's running with --privileged

You can using CgroupPermissions which is what a number of people use with synology devices.

See https://www.reddit.com/r/jellyfin/comments/exepia/synology_users_how_to_enable_hardware/fhv32z5/

I wouldn't have submitted this if it didn't work.

@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants