Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise SyntaxError when the field name is the same as Item's parameter… #18

Merged
merged 4 commits into from
May 18, 2019

Conversation

linw1995
Copy link
Owner

… in Item.

Fix #17

@linw1995 linw1995 added the bug Something isn't working label May 17, 2019
@codecov-io
Copy link

codecov-io commented May 17, 2019

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #18   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         148    167   +19     
  Branches       20     22    +2     
=====================================
+ Hits          148    167   +19
Impacted Files Coverage Δ
data_extractor/abc.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee4cc11...54a1c79. Read the comment docs.

@linw1995 linw1995 merged commit 99a4a7f into master May 18, 2019
@linw1995 linw1995 deleted the name_overwriten_error branch May 18, 2019 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The field name is the same as Item's parameter in Item.
2 participants