build: update to Node.js 22 TDE-1193 #1003
Open
+8
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blacha
reviewed
Jun 20, 2024
package.json
Outdated
| "stac-ts": "^1.0.0" | ||
| }, | ||
| "scripts": { | ||
| "build": "tsc", | ||
| "lint": "npx eslint . --ignore-path .gitignore", | ||
| "test": "node --test build/" | ||
| "test": "node --test" |
There was a problem hiding this comment.
I think it would be good to limit this to the build directory, node --test "build/**/*.test.js" otherwise its going to scan every single file in the git repo looking
l0b0
added a commit
that referenced
this pull request
Jun 20, 2024
Keep our software up to date, and get any useful features, fixes, and
optimisations from new versions of dependencies.
1. Update the engine:
```
jq '.engines.node = "^22.2.0"' package.json | sponge package.json
```
2. Update the lock file:
```
npm install
```
3. Update the uses of `linz/action-typescript`:
```
for path in .github/workflows/*.y*ml; do
yq --inplace '(.jobs.*.steps[] | select(.uses == "linz/action-typescript*").with.node-version) = "22.x"' "$path"
done
```
4. Update Dockerfile manifest digest:
```
sed --in-place --expression="s/^FROM node:.*/FROM node:22-slim@$(docker manifest inspect node:22-slim | jq --raw-output '.manifests[] | select(.platform.architecture == "amd64" and .platform.os == "linux") | .digest')/" Dockerfile
```
5. Run Node.js tests without an argument. Something changed in the
Node.js CLI in this release, breaking the old invocation.
> npm warn deprecated @types/prettier@3.0.0: This is a stub types > definition. prettier provides its own type definitions, so you do not > need this installed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Keep our software up to date, and get any useful features, fixes, and
optimisations from new versions of dependencies.
Modification
Update the engine:
Update the lock file:
Update the uses of
linz/action-typescript:Update Dockerfile manifest digest:
Checklist