Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to Node.js 22 TDE-1193 #1003

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

build: update to Node.js 22 TDE-1193 #1003

wants to merge 3 commits into from
+8 −19

Commits on Jun 20, 2024

  1. build: update to Node.js 22 TDE-1193 

    Keep our software up to date, and get any useful features, fixes, and
optimisations from new versions of dependencies.

1. Update the engine:

   ```
   jq '.engines.node = "^22.2.0"' package.json | sponge package.json
   ```
2. Update the lock file:

   ```
   npm install
   ```
3. Update the uses of `linz/action-typescript`:

   ```
   for path in .github/workflows/*.y*ml; do
       yq --inplace '(.jobs.*.steps[] | select(.uses == "linz/action-typescript*").with.node-version) = "22.x"' "$path"
   done
   ```
4. Update Dockerfile manifest digest:

   ```
   sed --in-place --expression="s/^FROM node:.*/FROM node:22-slim@$(docker manifest inspect node:22-slim | jq --raw-output '.manifests[] | select(.platform.architecture == "amd64" and .platform.os == "linux") | .digest')/" Dockerfile
   ```
5. Run Node.js tests without an argument. Something changed in the
   Node.js CLI in this release, breaking the old invocation.
    @l0b0
    l0b0 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    799bafc View commit details
    Browse the repository at this point in the history

  2. chore: Remove unneeded package 

    > npm warn deprecated @types/prettier@3.0.0: This is a stub types
> definition. prettier provides its own type definitions, so you do not
> need this installed.
    @l0b0
    l0b0 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2eee5ef View commit details
    Browse the repository at this point in the history

  3. refactor: Explicitly run each test script 

    As per
<#1003 (comment)>.
    @l0b0
    l0b0 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    02be826 View commit details
    Browse the repository at this point in the history