Simplify server pool #177
Simplify server pool #177
Conversation
|
@kornelski what would be the minimum supported Rust version for this? |
| pub(crate) static ref SERVER_POOL: ServerPool = ServerPool::new(DEFAULT_POOL_SIZE); | ||
| } | ||
| // macOS has small default ulimits | ||
| const DEFAULT_POOL_SIZE: usize = if cfg!(target_os = "macos") { 20 } else { 50 }; |
There was a problem hiding this comment.
there's test_server_pool_async and test_server_pool that might fail on a Mac now => please update the tests to use the values conditionally as well.
There was a problem hiding this comment.
These tests happen to pass currently, because they have a bug — the servers vec is emptied on every iteration, so they never exhaust the pool.
But when these tests actually try to get the whole pool, they cause a deadlock whenever any other test runs in parallel that uses more than one server at a time.
There was a problem hiding this comment.
right, that vec was supposed to be outside the for loop 🤦
|
Removal of lazy_static makes it 1.68.0 (vecdeque::new) |
That should be fine. Please update the new min supported toolchain in the CI files & the README |
|
Nice improvement, thank you 👍 |
Improvement for #171