Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unicode flag sequences #729

Closed
LukeTOBrien opened this issue Jun 23, 2020 · 4 comments · Fixed by #763
Closed

Unicode flag sequences #729

LukeTOBrien opened this issue Jun 23, 2020 · 4 comments · Fixed by #763

Comments

@LukeTOBrien
Copy link

Hello there,

I am working on an app which is basicly a Markdown editor and I am using your CSS flags in an Emoji popup that I have.
Users can select select an Emoji to add to their document and one of the Emoji categories is flags, so here I am using you SVG assets as backgound images.
The app is a long way from finished but I wanted to show you how I'm using your flag designs and as I noted some missing flags.

emoji-flags
Cool huh?

The missing flags I noted are:

  • AC => Ascension Island.
  • CP => Clipperton Island.
  • DG => Diego Garcia.
  • EA => Ceuta & Melilla.
  • IC => Canary Islands.
  • TA => Tristan Da Cunha.

Perhaps this is nickpicking a little bit.

Anyway I appreciate your effort and hard work, my app looks a little bit more professional now!
@LukeTOBrien LukeTOBrien mentioned this issue Jun 23, 2020
Closed
NotTsunami added a commit to NotTsunami/flag-icons that referenced this issue Oct 13, 2020
@NotTsunami
Add CP and EA flags
060dfe2 
* CP uses France flag
* EA uses Spain flag

Defined in Emoji 1.0 spec, partially addresses lipis#729
@NotTsunami NotTsunami mentioned this issue Oct 13, 2020
Merged
NotTsunami added a commit to NotTsunami/flag-icons that referenced this issue Oct 13, 2020
@NotTsunami
Add AC, CP, EA and TA flags
4fba902 
* AC and TA use St. Helena (SH) flag
* CP uses France (FR) flag
* EA uses Spain (ES) flag

Defined by Emoji 1.0 spec, partially addresses lipis#729
NotTsunami added a commit to NotTsunami/flag-icons that referenced this issue Oct 13, 2020
@NotTsunami
Add additional Emoji 1.0 flags
6b7a347 
* AC and TA use St. Helena (SH) flag
* CP uses France (FR) flag
* DG uses British Indian Ocean Territory (IO) flag
* EA uses Spain (ES) flag
* IC uses new flag

Defined by Emoji 1.0 spec, closes lipis#729
@NotTsunami
Copy link
Collaborator

Hi, I added all 6 flags (most reuse existing flags, as observed by existing emoji sets) in #763

@LukeTOBrien
Copy link
Author

Cool! Thanks!

@NotTsunami
Copy link
Collaborator

Wouldn't necessarily close this yet as it has yet to be merged. I have "Closes #729" in the git commit so once it is merged, it will automatically close this issue.

@LukeTOBrien
Copy link
Author

Hmmm, okay dokey if you insist

@LukeTOBrien LukeTOBrien reopened this Oct 13, 2020
NotTsunami added a commit to NotTsunami/flag-icons that referenced this issue Aug 9, 2021
@NotTsunami
Add additional Emoji 1.0 flags
865d402 
* AC and TA use St. Helena (SH) flag
* CP uses France (FR) flag
* DG uses British Indian Ocean Territory (IO) flag
* EA uses Spain (ES) flag
* IC uses new flag

Defined by Emoji 1.0 spec, closes lipis#729
@lipis lipis closed this as completed Oct 23, 2021
NotTsunami added a commit to NotTsunami/flag-icons that referenced this issue Oct 25, 2021
@NotTsunami
Add non-ISO Emoji 1.0 flags
e6cc8e7 
Adds in the following flags defined by Emoji 1.0:
* AC and TA use St. Helena (SH) flag
* CP uses France (FR) flag
* DG uses British Indian Ocean Territory (IO) flag
* EA uses Spain (ES) flag
* IC uses new flag

Closes lipis#729, closes lipis#272
@NotTsunami NotTsunami mentioned this issue Dec 11, 2023
Closed
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add additional Unicode/Emoji 1.0 flags NotTsunami/flag-icons
3 participants
@lipis @NotTsunami @LukeTOBrien