Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7581] add user reports to moderation comment serializer #18

Merged

Conversation

hklarner
Copy link
Contributor

@hklarner hklarner commented Aug 9, 2023

@hklarner hklarner force-pushed the hk-2023-08-add-user-reports-to-moderation-comment-serializer branch from 4d73289 to 52e51cc Compare August 9, 2023 13:27
@hklarner hklarner added the Dev: A4 depending PR or issue dependent on A4 label Aug 9, 2023
@github-actions
Copy link

github-actions bot commented Aug 9, 2023

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 13.95% 101/724
🔴 Branches 17.23% 66/383
🔴 Functions 11.79% 31/263
🔴 Lines 27.85% 677/2431

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 5ff8036

@hklarner hklarner force-pushed the hk-2023-08-add-user-reports-to-moderation-comment-serializer branch from 52e51cc to dc5b0b2 Compare August 10, 2023 08:34
@hklarner hklarner force-pushed the hk-2023-08-add-user-reports-to-moderation-comment-serializer branch from dc5b0b2 to 2f02595 Compare August 10, 2023 09:08
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, needs changelog and a test (at least add the user_reports field to the test_fields() I'd say)

@hklarner hklarner force-pushed the hk-2023-08-add-user-reports-to-moderation-comment-serializer branch from 2f02595 to d8ec376 Compare August 10, 2023 15:38
@hklarner
Copy link
Contributor Author

hklarner commented Aug 10, 2023

@goapunk no idea why I cannot reply + resolve your comment. Seems to be different for "review requested" than for "create comment". Anyways, I added a commit for your changes:

@hklarner hklarner force-pushed the hk-2023-08-add-user-reports-to-moderation-comment-serializer branch 2 times, most recently from 23669cd to e0c2819 Compare August 11, 2023 08:15
@goapunk goapunk self-requested a review August 14, 2023 15:34
Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the names of the response data (received_data[n] where n is 0 to 2) in the tests are a bit difficult to get in the assertions for which comments correspond.

@goapunk
Copy link
Contributor

goapunk commented Aug 14, 2023

the names of the response data (received_data[n] where n is 0 to 2) in the tests are a bit difficult to get in the assertions for which comments correspond.

I agree, it makes it harder to read and doesn't really reduce the line count. So I'm more in favor of easy readability here

Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only thing to maybe fix is the readability of the test

@hklarner hklarner force-pushed the hk-2023-08-add-user-reports-to-moderation-comment-serializer branch from e0c2819 to 5ff8036 Compare August 21, 2023 10:07
@hklarner
Copy link
Contributor Author

hklarner commented Aug 21, 2023

@goapunk @m4ra made changes to the readability of the test (renamed lists to comments_created and comments_received as discussed with @m4ra ), see

@hklarner hklarner requested review from goapunk and m4ra August 21, 2023 10:11
@m4ra m4ra merged commit 5b97640 into main Aug 21, 2023
4 checks passed
@m4ra m4ra deleted the hk-2023-08-add-user-reports-to-moderation-comment-serializer branch August 21, 2023 10:23
@hklarner
Copy link
Contributor Author

@goapunk @m4ra I will do a final rebase and add the review changes to the fitting commits once you approve. I can also do this every time I make changes - if you want - but I think it is easier for you to see the latest changes this way.

@m4ra
Copy link
Contributor

m4ra commented Aug 21, 2023

@goapunk @m4ra I will do a final rebase and add the review changes to the fitting commits once you approve. I can also do this every time I make changes - if you want - but I think it is easier for you to see the latest changes this way.

rebase happens automatically when we merge if there are no conflicts with the main branch.

@hklarner
Copy link
Contributor Author

rebase happens automatically when we merge if there are no conflicts with the main branch.

I meant getting rid of the two commits "pull request review changes".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dev: A4 depending PR or issue dependent on A4
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants