Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7543] extends report serializer #1477

Merged
merged 2 commits into from
Aug 21, 2023
Merged

[7543] extends report serializer #1477

merged 2 commits into from
Aug 21, 2023

Conversation

hklarner
Copy link
Contributor

@hklarner hklarner commented Aug 9, 2023 •
edited
Loading

No description provided.

@github-actions
Copy link

github-actions bot commented Aug 9, 2023 •
edited
Loading

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.38% 106/1130
🔴 Branches 10.77% 77/715
🔴 Functions 9.49% 35/369
🔴 Lines 15.69% 554/3532

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 9b49f9c

@hklarner hklarner force-pushed the hk-2023-08-refactors-report-serializer branch 2 times, most recently from 94d6bec to ece3882 Compare August 9, 2023 12:52
@hklarner hklarner mentioned this pull request Aug 9, 2023
Merged
goapunk
goapunk requested changes Aug 10, 2023
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally, it looks good to me. One small comment and it needs a changelog

@hklarner hklarner changed the title [7543] refactors report serializer [7543] extends report serializer Aug 11, 2023
@hklarner hklarner force-pushed the hk-2023-08-refactors-report-serializer branch from ece3882 to a66ebb8 Compare August 11, 2023 08:13
@goapunk goapunk requested a review from m4ra August 14, 2023 08:40
m4ra
m4ra requested changes Aug 14, 2023
View reviewed changes
adhocracy4/reports/serializers.py Show resolved Hide resolved
adhocracy4/reports/serializers.py Show resolved Hide resolved
@hklarner hklarner force-pushed the hk-2023-08-refactors-report-serializer branch from a66ebb8 to 9b49f9c Compare August 21, 2023 10:57
@hklarner hklarner requested review from goapunk and m4ra August 21, 2023 10:58
@m4ra m4ra merged commit f0cddd5 into main Aug 21, 2023
2 checks passed
@m4ra m4ra deleted the hk-2023-08-refactors-report-serializer branch August 21, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4ra m4ra m4ra approved these changes

@philli-m philli-m Awaiting requested review from philli-m

@goapunk goapunk Awaiting requested review from goapunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hklarner @goapunk @m4ra