[8164] apps/ai_reports: connect with external API #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
goapunk
commented
May 30, 2024
goapunk
commented
- add a celery task which sends a comment to the XAI server and saves the response as AiReport
- connect comment post_save signal with celery task
- rename category to label to be in line with the XAI response
- change AiReport fields to JSONField for now
- add tests
goapunk
force-pushed
the
jd-2024-05-connect-xai
branch
2 times, most recently
from
d97bf33
to
d3d8ea0
Compare
m4ra
reviewed
Jun 3, 2024
apps/ai_reports/signals.py
Outdated
| if getattr(settings, "XAI_API_URL", None): | ||
| comment_text_changed = getattr(instance, "_former_comment") != getattr( | ||
| instance, "comment" | ||
| ) |
There was a problem hiding this comment.
shouldn't use here the update_fields to check what's has been updated?
There was a problem hiding this comment.
as far as I understand update_fields can be:
None- > everything will be savedA list of fields-> only the fields in the list will be savedEmpty list-> nothing will be saved
So we can't get rid of the check in L19 as we don't know if the text changed in case 1
goapunk
force-pushed
the
jd-2024-05-connect-xai
branch
from
d3d8ea0
to
bb9f31b
Compare
goapunk
force-pushed
the
jd-2024-05-connect-xai
branch
2 times, most recently
from
e533682
to
103582a
Compare
goapunk
changed the title
m4ra
requested changes
Jun 3, 2024
| ) | ||
| if created or comment_text_changed: | ||
| # FIXME: use delay_on_commit() once updated to celery 5.x | ||
| get_classification_for_comment.delay(instance.pk) |
There was a problem hiding this comment.
the update needs a test for when comment is updated via the views, which comes from django rest api, and not sure if it performs an object save or update query. We only have a GET request test in tests/moderatorfeedback/test_moderator_comment_feedback_api.py
goapunk
force-pushed
the
jd-2024-05-connect-xai
branch
from
103582a
to
c09a972
Compare
- add a celery task which sends a comment to the XAI server and saves the response as AiReport - connect comment post_save signal with celery task - rename category to label to be in line with the XAI response - change AiReport fields to JSONField for now - add tests - **BREAKING CHANGE** Reset migrations for the ai_reports app (see changelog)
goapunk
force-pushed
the
jd-2024-05-connect-xai
branch
from
c09a972
to
e2cf219
Compare
goapunk
changed the title
|
@m4ra I also added manual migrations so we don't need to wipe the database for the ai_reports app, as there already was some manually created content on dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.