Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps/contrib: Add option to disable Matomo cookies #3169

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

rmader
Copy link
Contributor

@rmader rmader commented Sep 30, 2020

In order to avoid having to show a cookie banner.


This is actually for a+, but as meinberlin-dev is already set up on matomo, lets test the code here first.

In order to avoid having to show a cookie banner.
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! And do you want to put cookie_disabled into the pillar settings then?

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, could you actually add a test? If this is not [easily] testable for something else. Maybe we manage > 84%.

@rmader
Copy link
Contributor Author

rmader commented Oct 1, 2020

TBH, it doesn't make much sense to me just for the sake of pushing the number up :/
If I write tests, I would rather write them for something we can actually break by accident.

@fuzzylogic2000
Copy link
Contributor

Yes, awesome, then do that!

@rmader rmader merged commit 6caed6c into master Oct 1, 2020
@rmader rmader deleted the rm-2020-09-matomo-cookie branch October 1, 2020 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants