Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/projects/rules: added test to show initiator vs group member rights #4203

Merged
merged 1 commit into from
Feb 25, 2022

Conversation

sabinammm
Copy link
Contributor

Regarding Issue #4135
Added test to show that initiators in one organisation only have initator rights in another organisation, if they are group members of the specific project.

@github-actions
Copy link

github-actions bot commented Feb 25, 2022

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.6% 170/1770
🔴 Branches 7.01% 69/984
🔴 Functions 9.47% 52/549
🔴 Lines 13.61% 697/5120

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from b8182ee

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a bit confused about what's what here. But I think, it proves that the issue actually isn't one? No, it doesn't, because group1 needs to belong to orga1 to prove that? I will rewrite this a bit.

@sabinammm
Copy link
Contributor Author

I am a bit confused about what's what here. But I think, it proves that the issue actually isn't one? No, it doesn't, because group1 needs to belong to orga1 to prove that? I will rewrite this a bit.

My mistake: the initiator has to be taken out of group1 though. And then group1 is project1! Sorry, this is quite confusing...

@fuzzylogic2000
Copy link
Contributor

@sabinammm As you said, comments help! I hope... Could you have a look and then we have another talk? Also to talk about the issue, so you can show me, what's wrong on the page, now that we couldn't reproduce that in this test.

@sabinammm sabinammm force-pushed the sm-2022-02-initiator-group-member-rights branch from a3c97c1 to b8182ee Compare February 25, 2022 10:48
@sabinammm sabinammm merged commit 9ee6acf into main Feb 25, 2022
@sabinammm sabinammm deleted the sm-2022-02-initiator-group-member-rights branch February 25, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants