Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ks 2022 09 add module types #4449

Merged
merged 3 commits into from
Sep 9, 2022
Merged

Conversation

Rineee
Copy link
Contributor

@Rineee Rineee commented Sep 6, 2022

Also see liqd/adhocracy4#1207, which should be merged first. This PR is not really dependent on it, but without the A4 changes, new external projects/project containers/bplans wont get a type when saving.

@github-actions
Copy link

github-actions bot commented Sep 6, 2022

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.14% 165/1805
🔴 Branches 6.45% 67/1039
🔴 Functions 8.98% 51/568
🔴 Lines 13.12% 701/5342

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 2475928

Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration works perfectly! And for the settings, maybe we can change them a bit?

meinberlin/config/settings/base.py Show resolved Hide resolved
meinberlin/config/settings/base.py Show resolved Hide resolved
@Rineee Rineee changed the title Ks 2022 09 add module types WIP Ks 2022 09 add module types Sep 8, 2022
@Rineee Rineee changed the title WIP Ks 2022 09 add module types Ks 2022 09 add module types Sep 8, 2022
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@fuzzylogic2000 fuzzylogic2000 merged commit c60ac67 into main Sep 9, 2022
@fuzzylogic2000 fuzzylogic2000 deleted the ks-2022-09-add-module-types branch September 9, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants