Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add script to auto-generate changelog from changelog files #5534

Merged
merged 1 commit into from
Apr 22, 2024
Merged

add script to auto-generate changelog from changelog files #5534

merged 1 commit into from
Apr 22, 2024

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Feb 20, 2024 •
edited

Describe your changes
Briefly explain what you did and provide context for a clearer understanding.

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@goapunk goapunk requested a review from m4ra February 20, 2024 15:35
@goapunk goapunk changed the title add script to auto-generate changelog from changelog files WIP: add script to auto-generate changelog from changelog files Feb 20, 2024
m4ra
m4ra reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is it still in WIP? otherwise we can merge it.

@m4ra m4ra mentioned this pull request Feb 22, 2024
Closed
@goapunk goapunk changed the title WIP: add script to auto-generate changelog from changelog files add script to auto-generate changelog from changelog files Feb 22, 2024
@goapunk goapunk requested a review from m4ra February 22, 2024 17:28
@goapunk
Copy link
Contributor Author

goapunk commented Feb 22, 2024

Looks good, is it still in WIP? otherwise we can merge it.

I found some issues, is now ready

m4ra
m4ra approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@m4ra m4ra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m4ra m4ra merged commit 2ad0432 into main Apr 22, 2024
3 checks passed
@m4ra m4ra deleted the jd-2024-02-changelog-parser branch April 22, 2024 11:57
@goapunk goapunk mentioned this pull request Jun 5, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4ra m4ra m4ra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@goapunk @m4ra