Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8037] update a4forms/form_field.html and use it in all dashboard forms #5577

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Mar 19, 2024

…ib/form_field.html before the redesign, use for all dashboard forms

Describe your changes
I've updated the a4forms/form_field.html to be equal to the old meinberlin_contrib/form_field.html and swapped it out everywhere in the dashboard, so most or even all dashboard forms should be styled properly again.

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

…ib/form_field.html before the redesign, use for all dashboard forms
@goapunk goapunk force-pushed the jd-2024-03-update-form-field branch from 25832d2 to 4100aa3 Compare March 19, 2024 13:38
@goapunk goapunk requested review from m4ra and hom3mad3 April 2, 2024 09:02
@goapunk goapunk changed the title [8037] WIP: update a4forms/form_field.html and use it in all dashboard forms [8037] update a4forms/form_field.html and use it in all dashboard forms Apr 8, 2024
@hom3mad3
Copy link
Contributor

hom3mad3 commented Apr 9, 2024

@goapunk just wondering if those changes would that make it possible to delete meinberlin/templates/a4dashboard/includes/form_field.html (also replaced in the files where its being instantiated)?

@goapunk
Copy link
Contributor Author

goapunk commented Apr 9, 2024

@goapunk just wondering if those changes would that make it possible to delete meinberlin/templates/a4dashboard/includes/form_field.html (also replaced in the files where its being instantiated)?

We'll have to check if it's used somewhere in a4, otherwise we have to keep the overwrite. I'll have a look

@goapunk
Copy link
Contributor Author

goapunk commented Apr 9, 2024

@hom3mad3 it's used a lot in a4, so I think we need to keep it

Copy link
Contributor

@hom3mad3 hom3mad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good to me, though i haven't been able to actually test it due to not knowing where all the things are 🙈

@hom3mad3 hom3mad3 merged commit 76891c7 into dev Apr 9, 2024
3 checks passed
@hom3mad3 hom3mad3 deleted the jd-2024-03-update-form-field branch April 9, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants