Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8039] redesign item detail #5580

Merged
merged 2 commits into from
Apr 9, 2024
Merged

[8039] redesign item detail #5580

merged 2 commits into from
Apr 9, 2024

Conversation

hom3mad3
Copy link
Contributor

@hom3mad3 hom3mad3 commented Mar 25, 2024 •
edited
Loading

Description
Refactor and cleanup item detail section (except dropdown on a different pr)

Can be tested on localhost:8003/budgeting/2024-00014/

  • please make sure to add a photo to the item
  • dropdown is tackled in a different issue, so it looks broken right now:
    Screenshot 2024-03-26 at 11-58-55 Eco-Hub Empowering Communities for Sustainable Living — meinBerlin

Tasks

  • PR name contains story or task reference
  • Steps to recreate and test the changes
  • Documentation (docs and inline)
  • Tests (including n+1 and django_assert_num_queries where applicable)
  • Changelog

@hom3mad3 hom3mad3 changed the title [8039] redesign item detail WIP [8039] redesign item detail Mar 25, 2024
@hom3mad3 hom3mad3 force-pushed the mr-2024-03-redesign-item-detail branch from b30eb02 to 5eeee69 Compare March 26, 2024 10:59
@hom3mad3 hom3mad3 mentioned this pull request Mar 26, 2024
Merged
5 tasks
@hom3mad3 hom3mad3 changed the title WIP [8039] redesign item detail [8039] redesign item detail Mar 26, 2024
@hom3mad3 hom3mad3 requested a review from goapunk March 26, 2024 11:08
goapunk
goapunk requested changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good, some comments on the image and the mobile design

meinberlin/apps/contrib/templates/meinberlin_contrib/item_detail.html Outdated Show resolved Hide resolved
meinberlin/apps/contrib/templates/meinberlin_contrib/item_detail.html Show resolved Hide resolved
meinberlin/assets/scss/components/_item_detail.scss Outdated Show resolved Hide resolved
@hom3mad3 hom3mad3 force-pushed the mr-2024-03-redesign-item-detail branch from c1cd2eb to df5fa85 Compare April 8, 2024 14:06
@hom3mad3 hom3mad3 force-pushed the mr-2024-03-redesign-item-detail branch from df5fa85 to dfe4656 Compare April 8, 2024 17:44
@hom3mad3 hom3mad3 force-pushed the mr-2024-03-redesign-item-detail branch from dfe4656 to e71a36c Compare April 8, 2024 17:46
@hom3mad3 hom3mad3 requested a review from goapunk April 9, 2024 07:16
goapunk
goapunk approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@goapunk goapunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, the mobile image still seems a bit weird but I guess marcelo will complain if it should be different.

@goapunk goapunk merged commit ff0f8fa into dev Apr 9, 2024
3 checks passed
@goapunk goapunk deleted the mr-2024-03-redesign-item-detail branch April 9, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goapunk goapunk goapunk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hom3mad3 @goapunk