Ka 2020 04 translate org fields #1799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1768 It makes the buttons switch between the languages, and all languages addable (if they aren't already there) and removable (if they are there) on the plus-button. The jQuery was there to choose the right language for the tabs, which are in the html. So, currently if a language is removed that was active on the tabs, The tab content is still shown, while no button is active and the respective language is removed when saving.
…st-switch My first thought was to move the tabs into the react component, but that would have been a lot of effort. Instead (to make it slightly less confusing), I added a second dropdown (-) to remove languages and use the first dropdown (+) only add them.
fuzzylogic2000
commented
Apr 3, 2020
| this.props.languages.map(languageCode => { | ||
| this.props.languages.map((languageCode, i) => { | ||
| return ( | ||
| <span key={languageCode}> |
There was a problem hiding this comment.
@phillimorland I am a bit unhappy with returning an empty span for the languages that shouldn't be in the list, but couldn't think of a better way. (Apart from also having a list of the inactive languages in the state, but that would be a bit annoying to always update two lists, then.)
There was a problem hiding this comment.
i think this is ok for now to be honest
philli-m
approved these changes
Apr 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are long explanations in the commits. Please read them separately.