Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

communitydebate/views: initialize upload forms when form is not valid #2056

Merged
merged 2 commits into from
Oct 20, 2020

Conversation

Rineee
Copy link
Contributor

@Rineee Rineee commented Oct 16, 2020

fixes https://sentry.liqd.net/sentry/opin-prod/issues/1198/events/

I think we have contradictory linters now? When trying to commit, I got:

/home/katharinaschmid/a4-opin/euth/documents/static/documents/Paragraph.jsx
119:19 error Expected indentation of 20 space characters but found 18 react/jsx-indent-props

So I changed that and then got:

/home/katharinaschmid/a4-opin/euth/documents/static/documents/Paragraph.jsx
119:1 error Expected indentation of 18 spaces but found 20 indent

@philli-m
Copy link
Contributor

@Rineee when adding document file but no title then both form field errors are triggered instead of just the title error, doesn't do it other way around, is this to do with this?
Oh and linting errors should be fixed after config merge and rebase

@Rineee
Copy link
Contributor Author

Rineee commented Oct 20, 2020

@Rineee when adding document file but no title then both form field errors are triggered instead of just the title error, doesn't do it other way around, is this to do with this?
Oh and linting errors should be fixed after config merge and rebase

No, this doesnt have to do with this and must have been there before, which doesnt really make it better... will look into it!

@philli-m
Copy link
Contributor

will add issue for the image error message

@philli-m philli-m merged commit 42fb4ae into master Oct 20, 2020
@philli-m philli-m deleted the ks-2020-10-fix-community-debate-upload-forms-error branch October 20, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants