Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/tiles: using combination of overflow-wrap hyphens and smaller… #1869

Merged
merged 1 commit into from May 30, 2022

Conversation

khamui
Copy link
Contributor

@khamui khamui commented May 25, 2022

… fontsize to asssure proper word wrapping.

This is one approach to close #1780

As spoken with @mcastro-lqd the font-size used is too big. So i am using <h4> rather than modifying <h3> (there is a systematic behind it with screen sizes etc.)

Then to word-wrap the css property overflow-wrap is used to not allow wrapping on weird places.

Additionally using css property hyphens, but only for smaller screen sizes, otherwise it will wrap quite earlier and look weird. And also languages are not very well supported in browsers other than english/german (see caniuse.com)

@github-actions
Copy link

github-actions bot commented May 25, 2022

Coverage report

Total coverage

Status Category Percentage Covered / Total
🟢 Statements 100% 0/0
🟢 Branches 100% 0/0
🟢 Functions 100% 0/0
🟢 Lines 100% 0/0

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from d90a81a

… fontsize to asssure proper word wrapping

squash
@khamui khamui force-pushed the kt-2022-05-hyphen-project-tiles branch from 11dbc34 to d90a81a Compare May 30, 2022 11:13
Copy link
Contributor

@fuzzylogic2000 fuzzylogic2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
About the h3 that maybe shouldn't be there, we should probably check that. Could you open an issue and write down, what we have for headings on that (project detail) page and also which ones can get in there?

@fuzzylogic2000 fuzzylogic2000 merged commit 789778a into main May 30, 2022
@fuzzylogic2000 fuzzylogic2000 deleted the kt-2022-05-hyphen-project-tiles branch May 30, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

long title on tile for module: line break within word
2 participants