Fix #2341: Replace liqd/django-autoslug dependency to upstream #2446
Conversation
| @@ -16,7 +16,7 @@ urllib3==1.26.15 | |||
| # Inherited a4-core requirements | |||
| Django==3.2.19 | |||
| django-allauth==0.54.0 | |||
| git+https://github.com/liqd/django-autoslug.git@liqd2212#egg=django-autoslug | |||
There was a problem hiding this comment.
Looks like a4-core also uses this dep., I'll initiate a PR there as well so that we can archive/delete (if needed) liqd/django-autoslug once bother the PRs are merged.
There was a problem hiding this comment.
Done! (Initiated a PR liqd/adhocracy4#1413)
|
Hey @DubeySandeep, thanks for your PRs and contributions! We are currently discussing internally whether we should have a CLA for external contributors. We probably shouldn't have one as it makes contributing harder but as this is a team decision it will still take us some time and I would like to wait until then before we merge this, sorry! |
|
@goapunk Thanks for the review and the heads-up! I think it's a good idea to have a CLA (assuming t will be a simple form (max 3 inputs)), I'm fine with signing the CLA, let me know once you have an update! :) Also, it looks like we are using a secret (secret.COV) which is not permissible to forked PRs build (ref), resulting into empty string value for the token and blocking my PR build to complete the Possible solutions: |
|
Hi @goapunk, I wanted to check whether you have any updates on the CLA requirements. |
|
Hi @DubeySandeep, sorry for the late reply and thanks again for your contribution. We should have something ready by the end of the week. We'll also look into fixing the CI/Coveralls for external PRs, thanks for reporting the issue and the suggestions! |
|
superseded by #2710 |
Overview
This PR fixes #2341 by replacing the forked/edited django-autoslug (introduced via #2188) with its original upstream.
This is possible now as the changes made on the forked repo are merged and released upstream.
Manual testing
Able to install the latest upstream django-autoslug via pip
Able to run the server with the latest version of django-autoslug
