fix flaky email tests #2546
Merged
fix flaky email tests #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goapunk
force-pushed
the
jd-2023-12-email-tests-flaky
branch
2 times, most recently
from
c8980f6
to
61df8aa
Compare
goapunk
force-pushed
the
jd-2023-12-email-tests-flaky
branch
from
61df8aa
to
f450f81
Compare
goapunk
commented
Dec 21, 2023
| @@ -0,0 +1,14 @@ | |||
| # Tests | |||
goapunk
commented
Dec 21, 2023
|
|
||
| #### Testing Emails | ||
|
|
||
| Emails are not guaranteed to be sent in a deterministic order, so checking |
There was a problem hiding this comment.
we should probably also check the other tests at some point
m4ra
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tasks