Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: rename fontawesome icons to v6 #1394

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

WIP: rename fontawesome icons to v6 #1394

wants to merge 2 commits into from

Conversation

goapunk
Copy link
Contributor

@goapunk goapunk commented Apr 18, 2023

requires updating to fontawesome v6 in all projects

@goapunk goapunk requested review from philli-m and khamui April 18, 2023 09:40
@github-actions
Copy link

github-actions bot commented Apr 18, 2023 •
edited
Loading

Coverage report

Total coverage

Status Category Percentage Covered / Total
🔴 Statements 9.39% 106/1129
🔴 Branches 10.86% 77/709
🔴 Functions 9.56% 35/366
🔴 Lines 15.72% 554/3525

Status of coverage: 🟢 - ok, 🟡 - slightly more than threshold, 🔴 - under the threshold

Report generated by 🧪jest coverage report action from 3c4cb0f

philli-m
philli-m suggested changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@philli-m philli-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as we are touching all the files anyway I would update all classes to their current naming convention

adhocracy4/comments_async/static/comments_async/filter_search.jsx Outdated Show resolved Hide resolved
@goapunk goapunk requested a review from philli-m April 20, 2023 13:55
@goapunk goapunk changed the title rename fontawesome icons to v6 WIP: rename fontawesome icons to v6 Apr 20, 2023
@goapunk
rename fontawesome icons for v6
2e405d6 
* rename fas -> fa-solid
* rename far -> fa-regular
@goapunk goapunk changed the title WIP: rename fontawesome icons to v6 rename fontawesome icons to v6 Apr 20, 2023
@goapunk goapunk changed the title rename fontawesome icons to v6 WIP: rename fontawesome icons to v6 Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khamui khamui Awaiting requested review from khamui

@philli-m philli-m Awaiting requested review from philli-m

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goapunk @philli-m