[#7267 #7264] serve nav menu dependent on url and add ls to footer #692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philli-m
commented
May 3, 2023
philli-m
force-pushed
the
pm-2023-5-nav-menus
branch
4 times, most recently
from
5ff216e
to
bedcc68
Compare
Rineee
reviewed
May 4, 2023
|
@philli-m I added a commit that adds a template tag to decide if there is content. Although it relies on the naming of the panels, which is not ideal, but I think there is no other way? I added a comment, although a test would probably be better 🤣 Should we document it somewhere else? I spoke to Max and he said that if there is any content, the page should be displayed as it is very unlikely that only e.g. the title will be filled. I guess thats true, but maybe a helptext in the easy language tab could also explain the behaviour that the page is displayed if any of the fields are filled? |
Rineee
force-pushed
the
pm-2023-5-nav-menus
branch
from
aef2f24
to
4118482
Compare
fuzzylogic2000
approved these changes
May 8, 2023
…/footer menu and add helptext and ls link to footer with translation
…sy content and use in templates
fuzzylogic2000
force-pushed
the
pm-2023-5-nav-menus
branch
from
4118482
to
ff51e61
Compare
fuzzylogic2000
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This is does not include the functionality to go back to LS homepage if no LS content on current page when lang switch changed.