Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump golangci-lint version from 1.52.0 to 1.53.3 #1921

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Bump golangci-lint version from 1.52.0 to 1.53.3 #1921

merged 1 commit into from
Jul 26, 2023

Conversation

cheina97
Copy link
Member

Description

This PR upgrade the used golangci-lint version and disables the golang cache (suggested in golangci-lint-action docs)

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97
Copy link
Member Author

/rebase test=true

@cheina97 cheina97 requested review from aleoli and fra98 July 25, 2023 16:12
@aleoli
Copy link
Member

aleoli commented Jul 26, 2023

/rebase test=true

@cheina97
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jul 26, 2023
@adamjensenbot adamjensenbot merged commit 59b7f57 into liqotech:master Jul 26, 2023
13 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jul 26, 2023
@cheina97 cheina97 deleted the frc/golangci-dump branch July 26, 2023 11:02
@cheina97 cheina97 mentioned this pull request Aug 1, 2023
Merged
@cheina97 cheina97 added the dependencies Pull requests that update a dependency file label Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@fra98 fra98 Awaiting requested review from fra98

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cheina97 @adamjensenbot @aleoli