Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: disable linter cache #1934

Merged
merged 1 commit into from
Aug 2, 2023
Merged

CI: disable linter cache #1934

merged 1 commit into from
Aug 2, 2023

Conversation

cheina97
Copy link
Member

@cheina97 cheina97 commented Aug 1, 2023 •
edited

Description

This PR disables the cache, in linter workflow, for golangci-lint.

This change has already been applied in #1921 but it has been reverted accidentally in #1922

@adamjensenbot
Copy link
Collaborator

Hi @cheina97. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /hold, /unhold Add/remove the hold label to prevent merging with /merge

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@cheina97
Copy link
Member Author

cheina97 commented Aug 1, 2023

/rebase test=true

@cheina97 cheina97 added the github_actions Pull requests that update GitHub Actions code label Aug 1, 2023
@cheina97 cheina97 requested a review from fra98 August 1, 2023 09:12
@cheina97
Copy link
Member Author

cheina97 commented Aug 1, 2023

/rebase test=true

1 similar comment
@cheina97
Copy link
Member Author

cheina97 commented Aug 1, 2023

/rebase test=true

@aleoli
Copy link
Member

aleoli commented Aug 2, 2023

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Aug 2, 2023
@adamjensenbot adamjensenbot merged commit 442cdba into liqotech:master Aug 2, 2023
17 of 19 checks passed
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Aug 2, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 4, 2023
Merged
@cheina97 cheina97 deleted the frc/disablecachelint branch August 16, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleoli aleoli aleoli approved these changes

@fra98 fra98 fra98 approved these changes

Assignees
No one assigned
Labels
github_actions Pull requests that update GitHub Actions code size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@cheina97 @adamjensenbot @aleoli @fra98