-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixing and enhancement network operators #268
Conversation
7980d00
to
e772db1
Compare
Pull Request Test Coverage Report for Build 260901563
💛 - Coveralls |
94d501b
to
62e91c6
Compare
62e91c6
to
9e5697f
Compare
@@ -196,7 +219,7 @@ func (r *RouteController) createAndInsertIPTablesChains() error { | |||
} else { | |||
log.Info("created", "chain", LiqonetPreroutingChain, "in table", NatTable) | |||
} | |||
r.IPTablesChains[LiqonetPostroutingChain] = liqonetOperator.IPTableChain{ | |||
r.IPTablesChains[LiqonetPreroutingChain] = liqonetOperator.IPTableChain{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity: Why do we moved to PreRoutingChain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was a little bug where we saved the LiqonetPreroutingChain as the LiqonetPostroutingChain in the IPTablesChains table. Looking at line 217 it is creating the LiqonetPreroutingChain.
412f101
to
6ce0f3f
Compare
/rebase |
Rebase status: success! |
6ce0f3f
to
1290921
Compare
1290921
to
96865af
Compare
/rebase |
…is set "Ready" when it can be processed by the route and tunnnel operators Bugfixing network operators
Rebase status: success! |
96865af
to
f1f4775
Compare
Description
This PR brings bugfixing and some refactoring of the network operators
TunnelEndpointCreator
The
tunnelendpoints.net.liqo.io
resource is created now in one step, specifying the spec and status field at once. It used to first create the resource with the spec field, wait for the creation and then update the status field. This process is now delegated to the client-go library.A newly created
tunnelendpoint
resource has the status field namedphase
set to Ready. This is needed for the tunnel and route operators. Otherwise the resource may be consumed before that some status fields are set.Route-Operator
events
are sent to the resource been reconciledThis way if an error occurs the user knows which instance/node to check for misconfiguration. If an error occurs while removing the external resources it is reported through an event on the related
tunnelendpoint
resource and waits for the user to solve the conflicts.Tunnel-Operator
tunnelendpoints
resources if restarted.tunnelendpoint
resource.Fixes #(issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
Existing unit and integration test have been updated to use the status field
phase
with new value which for now could be set to Ready only.