Bug fixing and enhancement network operators #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alacuku
force-pushed
the
kcl/networkmodule
branch
2 times, most recently
from
7980d00
to
e772db1
Compare
Pull Request Test Coverage Report for Build 260901563
💛 - Coveralls |
alacuku
force-pushed
the
kcl/networkmodule
branch
6 times, most recently
from
94d501b
to
62e91c6
Compare
alacuku
changed the title
alacuku
force-pushed
the
kcl/networkmodule
branch
from
62e91c6
to
9e5697f
Compare
alacuku
changed the title
palexster
reviewed
Sep 17, 2020
| @@ -196,7 +219,7 @@ func (r *RouteController) createAndInsertIPTablesChains() error { | |||
| } else { | |||
| log.Info("created", "chain", LiqonetPreroutingChain, "in table", NatTable) | |||
| } | |||
| r.IPTablesChains[LiqonetPostroutingChain] = liqonetOperator.IPTableChain{ | |||
| r.IPTablesChains[LiqonetPreroutingChain] = liqonetOperator.IPTableChain{ | |||
There was a problem hiding this comment.
Out of curiosity: Why do we moved to PreRoutingChain?
There was a problem hiding this comment.
it was a little bug where we saved the LiqonetPreroutingChain as the LiqonetPostroutingChain in the IPTablesChains table. Looking at line 217 it is creating the LiqonetPreroutingChain.
palexster
approved these changes
Sep 17, 2020
alacuku
force-pushed
the
kcl/networkmodule
branch
2 times, most recently
from
412f101
to
6ce0f3f
Compare
palexster
approved these changes
Sep 18, 2020
|
/rebase |
|
Rebase status: success! |
adamjensenbot
force-pushed
the
kcl/networkmodule
branch
from
6ce0f3f
to
1290921
Compare
fraborg
reviewed
Sep 18, 2020
alacuku
force-pushed
the
kcl/networkmodule
branch
from
1290921
to
96865af
Compare
|
/rebase |
…is set "Ready" when it can be processed by the route and tunnnel operators Bugfixing network operators
|
Rebase status: success! |
adamjensenbot
force-pushed
the
kcl/networkmodule
branch
from
96865af
to
f1f4775
Compare
fraborg
approved these changes
Sep 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR brings bugfixing and some refactoring of the network operators
TunnelEndpointCreator
The
tunnelendpoints.net.liqo.ioresource is created now in one step, specifying the spec and status field at once. It used to first create the resource with the spec field, wait for the creation and then update the status field. This process is now delegated to the client-go library.A newly created
tunnelendpointresource has the status field namedphaseset to Ready. This is needed for the tunnel and route operators. Otherwise the resource may be consumed before that some status fields are set.Route-Operator
eventsare sent to the resource been reconciledThis way if an error occurs the user knows which instance/node to check for misconfiguration. If an error occurs while removing the external resources it is reported through an event on the related
tunnelendpointresource and waits for the user to solve the conflicts.Tunnel-Operator
tunnelendpointsresources if restarted.tunnelendpointresource.Fixes #(issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.
Existing unit and integration test have been updated to use the status field
phasewith new value which for now could be set to Ready only.