Move the DNS/WAN discovery to use the new AuthService #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aleoli. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
aleoli
force-pushed
the
aol/dns-discovery
branch
from
d03f84a
to
73c4110
Compare
aleoli
force-pushed
the
aol/dns-discovery
branch
6 times, most recently
from
5495e08
to
7fd0408
Compare
aleoli
changed the title
aleoli
force-pushed
the
aol/dns-discovery
branch
from
7fd0408
to
83bebc7
Compare
aleoli
changed the title
AbakusW
reviewed
Dec 17, 2020
AbakusW
approved these changes
Dec 17, 2020
palexster
reviewed
Dec 17, 2020
internal/discovery/search-domain-operator/search-domain-controller.go
Outdated
Show resolved
Hide resolved
palexster
reviewed
Dec 17, 2020
aleoli
force-pushed
the
aol/dns-discovery
branch
from
83bebc7
to
46e454c
Compare
|
/rebase |
adamjensenbot
force-pushed
the
aol/dns-discovery
branch
from
46e454c
to
683aa5d
Compare
mlavacca
reviewed
Dec 23, 2020
pkg/discovery/const.go
Outdated
| @@ -4,6 +4,7 @@ const ( | |||
| ClusterIdLabel = "liqo.io/cluster-id" | |||
| AuthTokenLabel = "liqo.io/auth-token" | |||
| RemoteIdentityLabel = "liqo.io/remote-identity" | |||
| DiscoveryTypeLabel = "liqo.io/discovery-type" | |||
There was a problem hiding this comment.
what do you think about adding the discovery prefix to all these labels?
There was a problem hiding this comment.
Do you mean something like "discovery.liqo.io/..."?
There was a problem hiding this comment.
if you think it is appropriate for these labels of course
aleoli
force-pushed
the
aol/dns-discovery
branch
from
683aa5d
to
032115c
Compare
mlavacca
approved these changes
Dec 23, 2020
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way to do WAN discovery with DNS
Now, we have to discover the AuthService to get foreign cluster information. SRV records are enow pointing to the ingress/service that is exposing the AuthService on the foreign cluster
The registration of the home cluster is simpler than before, no TXT record is needed because those data are retrieved from the new service as for LAN discovery
ref. issue #371