Add initial ARM support #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @palexster. Thanks for your PR! I am @adamjensenbot.
Make sure this PR appears in the liqo changelog, adding one of the following labels:
|
Pull Request Test Coverage Report for Build 655187273
💛 - Coveralls |
giorio94
previously approved these changes
Mar 15, 2021
| @@ -3,7 +3,7 @@ ENV PATH /go/bin:/usr/local/go/bin:$PATH | |||
| ENV GOPATH /go | |||
| COPY . /go/src/github.com/liqotech/liqo | |||
| WORKDIR /go/src/github.com/liqotech/liqo | |||
| RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build ./cmd/advertisement-broadcaster/ | |||
| RUN CGO_ENABLED=0 GOOS=linux GOARCH=$(go env GOARCH) go build ./cmd/advertisement-broadcaster/ | |||
| RUN cp advertisement-broadcaster /usr/bin/advertisement-broadcaster | |||
|
|
|||
| FROM scratch | |||
There was a problem hiding this comment.
For the future, it may be worth to uniform the base image for the different controllers. Probably, alpine or busybox are good compromises as they allow some basic debugging with no particular effort
alacuku
approved these changes
Mar 16, 2021
giorio94
approved these changes
Mar 16, 2021
|
/merge |
adamjensenbot
added
the
merge-requested
adamjensenbot
removed
the
merge-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces first support for ARM64 architecture.