Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Virtual Kubelet Node Controller 2/6 #582

Merged
merged 1 commit into from
Apr 27, 2021
Merged

Virtual Kubelet Node Controller 2/6 #582

merged 1 commit into from
Apr 27, 2021

Conversation

mlavacca
Copy link
Member

@mlavacca mlavacca commented Apr 22, 2021 •
edited
Loading

Description

This PR is the second related to the NodeController refactoring.

What has been done:

  • move and NodeFromProvider functions from /cmd to /pkg/...

What has to be done yet:

  • move NodeErrorHandler from cmd to the NodeController.

address #474

@adamjensenbot
Copy link
Collaborator

Hi @mlavacca. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /ok-to-test Enable testing for PRs with base on forks

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@adamjensenbot
Copy link
Collaborator

Hi @mlavacca. Thanks for your PR!

I'm waiting for a Liqo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

@adamjensenbot
Copy link
Collaborator

Hi @mlavacca. Thanks for your PR!

I'm waiting for a Liqo member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

@mlavacca mlavacca changed the title nodeProvider pkg created [WIP] nodeProvider pkg created Apr 22, 2021
@mlavacca
Copy link
Member Author

/ok-to-test

@mlavacca mlavacca changed the title [WIP] nodeProvider pkg created [WIP] Virtual Kubelet Node Controller 2/6 Apr 22, 2021
@mlavacca
Copy link
Member Author

/rebase

@mlavacca mlavacca changed the title [WIP] Virtual Kubelet Node Controller 2/6 Virtual Kubelet Node Controller 2/6 Apr 27, 2021
@mlavacca
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Apr 27, 2021
@adamjensenbot adamjensenbot merged commit 94b5c92 into liqotech:master Apr 27, 2021
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palexster palexster palexster approved these changes

@aleoli aleoli aleoli approved these changes

@alacuku alacuku Awaiting requested review from alacuku

@giorio94 giorio94 Awaiting requested review from giorio94

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mlavacca @adamjensenbot @palexster @aleoli