Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Linting on branch master and releases #704

Merged
merged 1 commit into from
Jun 23, 2021

Conversation

palexster
Copy link
Member

Description

We recently introduced a stricter linter on the Liqo code. The intention is to gradually improve the average quality and uniform the style of the repository.

Since we decided to have a gradual approach, this check is always broken on the main branch bringing a "broken window" effect on the repository status.

This PR drops the execution of such check on the main branch and releases, leaving it only for PRs.

How Has This Been Tested?

This PR introduces no functional changes to the code.

@adamjensenbot
Copy link
Collaborator

Hi @palexster. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch
  • /merge: Merge this PR into the master branch
  • /ok-to-test Enable testing for PRs with base on forks

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@palexster
Copy link
Member Author

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Jun 23, 2021
@adamjensenbot adamjensenbot merged commit a4a0da9 into master Jun 23, 2021
@adamjensenbot adamjensenbot deleted the apa/disable-lint-master branch June 23, 2021 15:39
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants