Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support For OwnerReferencesPermissionEnforcement Admission Controller #896

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Add Support For OwnerReferencesPermissionEnforcement Admission Controller #896

merged 1 commit into from
Sep 20, 2021

Conversation

aleoli
Copy link
Member

@aleoli aleoli commented Sep 16, 2021 •
edited
Loading

Description

This pr add the support for the OwnerReferencesPermissionEnforcement admission controller.

How Has This Been Tested?

  • locally on KinD
  • add unit test

@adamjensenbot
Copy link
Collaborator

Hi @aleoli. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /doc-build Trigger the build of the Liqo documentation

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@aleoli aleoli force-pushed the aol/fix-permissions branch 3 times, most recently from 819b77d to 2f334ff Compare September 17, 2021 08:21
@pull-request-size pull-request-size bot added size/L and removed size/M labels Sep 17, 2021
@aleoli
Copy link
Member Author

aleoli commented Sep 17, 2021

/build

@aleoli aleoli force-pushed the aol/fix-permissions branch 4 times, most recently from d586732 to f947380 Compare September 17, 2021 12:02
@aleoli
Copy link
Member Author

aleoli commented Sep 17, 2021

/test

@aleoli aleoli changed the title Fix Permissions Add Support For OwnerReferencesPermissionEnforcement Admission Controller Sep 17, 2021
@aleoli aleoli marked this pull request as ready for review September 17, 2021 13:52
@palexster
Copy link
Member

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Sep 20, 2021
@adamjensenbot adamjensenbot merged commit ed3340c into master Sep 20, 2021
@adamjensenbot adamjensenbot deleted the aol/fix-permissions branch September 20, 2021 12:31
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Sep 20, 2021
@aleoli aleoli mentioned this pull request Sep 23, 2021
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palexster palexster palexster approved these changes

@giorio94 giorio94 giorio94 approved these changes

@alacuku alacuku Awaiting requested review from alacuku

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aleoli @adamjensenbot @palexster @giorio94