Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liqoctl: Fix error message on missing kubeconfig #954

Merged
merged 3 commits into from
Oct 21, 2021
Merged

liqoctl: Fix error message on missing kubeconfig #954

merged 3 commits into from
Oct 21, 2021

Conversation

CapacitorSet
Copy link
Contributor

Description

Makes liqoctl print an error message if KUBECONFIG is not set (it currently exits silently).

Fixes #952.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Manual testing

@adamjensenbot
Copy link
Collaborator

Hi @CapacitorSet. Thanks for your PR!

I am @adamjensenbot.
You can interact with me issuing a slash command in the first line of a comment.
Currently, I understand the following commands:

  • /rebase: Rebase this PR onto the master branch (You can add the option test=true to launch the tests
    when the rebase operation is completed)
  • /merge: Merge this PR into the master branch
  • /build Build Liqo components
  • /test Launch the E2E and Unit tests
  • /doc-build Trigger the build of the Liqo documentation

Make sure this PR appears in the liqo changelog, adding one of the following labels:

  • kind/breaking: 💥 Breaking Change
  • kind/feature: 🚀 New Feature
  • kind/bug: 🐛 Bug Fix
  • kind/cleanup: 🧹 Code Refactoring
  • kind/docs: 📝 Documentation

@CapacitorSet
Copy link
Contributor Author

/test

@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 19, 2021
@CapacitorSet
Copy link
Contributor Author

/test

1 similar comment
@CapacitorSet
Copy link
Contributor Author

/test

@palexster
Copy link
Member

/rebase

@palexster
Copy link
Member

/test

@palexster
Copy link
Member

/merge

@adamjensenbot adamjensenbot added the merge-requested Request bot merging (automatically managed) label Oct 21, 2021
@adamjensenbot adamjensenbot merged commit 7f966b4 into liqotech:master Oct 21, 2021
@adamjensenbot adamjensenbot removed the merge-requested Request bot merging (automatically managed) label Oct 21, 2021
@CapacitorSet CapacitorSet deleted the liqoctl-fix-no-kubeconfig branch October 21, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] liqoctl generate-add-command error management
5 participants