Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix signature #23

Closed
wants to merge 1 commit into from
Closed

fix signature #23

wants to merge 1 commit into from

Conversation

dbarchuk
Copy link

When try to create signature got
TypeError: LiqPay._make_signature() takes 3 positional arguments but 4 were given
because of doubling argument self._private_key)

@aorzh
Copy link

aorzh commented Feb 19, 2024

Hi @dbarchuk! I've wrote a fork https://github.com/aorzh/liqpay-sdk-python3 because this repo hasn't updates few years. I used this fork in production but it's of course not official.
Also, as I see one contributor of current repo already made some changes. Here is his comment: #17 (comment)

And here is branch where I see actual changes: https://github.com/liqpay/sdk-python/tree/dev_1.1

@dbarchuk
Copy link
Author

Hi @dbarchuk! I've wrote a fork https://github.com/aorzh/liqpay-sdk-python3 because this repo hasn't updates few years. I used this fork in production but it's of course not official. Also, as I see one contributor of current repo already made some changes. Here is his comment: #17 (comment)

And here is branch where I see actual changes: https://github.com/liqpay/sdk-python/tree/dev_1.1

I noticed that this repository was last updated three months ago, so I decided to test it. Upon encountering an error, I checked the issues section and found it already reported. I thought perhaps submitting a pull request would be the quickest way to resolve it. Also, I admit I'm too lazy to check all the branches ;)

While it's not a problem to write a custom class instead of using this package (even though it was recommended by the official Liqpay documentation), I just want to ensure it's fixed for the future.

@dbarchuk dbarchuk closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants