fix: allow to set changelog-lock-wait-time-in-minutes to 0

[jgarec]

Fixes #331

If not, when changelog-lock-wait-time-in-minutes is set to 0 and no lock is in the database, it fails with an error "Could not acquire change log lock. Currently locked by UNKNOWN"

[KushnirykOleh]

Hi @jgarec, thank you for submitting PR.
It fixes issue, but I found 2 things that would be good to improve before merging

• test that you added passed both with and without changes in AbstractNoSqlLockService if changelog-lock-wait-time-in-minutes is not set to 0 somewhere outside of test
• if lock is locked, and changelog-lock-wait-time-in-minutes is set to 0 it takes additional 10 seconds to fail as it executes Thread.sleep(getChangeLogLockRecheckTime() * 1000); once and default changeLogLockRecheckTime is 10 seconds. What reduces value of setting changelog-lock-wait-time-in-minutes to zero.

[jgarec]

About your second remark, i think it's better now

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[vitaliimak]

Hello @jgarec.
Thank you for your effort! Your fix looks good to me.
However, during the internal discussion, we concluded to avoid changing the timeouts Liquibase product behaviors in the extension for a specific database.
Would you be interested in suggesting the same fix for Liquibase core? (https://github.com/liquibase/liquibase/blob/master/liquibase-standard/src/main/java/liquibase/lockservice/StandardLockService.java#L253)
If the proposed change gets accepted by the Liquibase core team, we can than reflect it into the extension.

[jgarec]

hello @vitaliimak, a similar fix is now included in liquibase core : liquibase/liquibase#4609

[vitaliimak]

Hi @jgarec
Thank you for the reminder.
I see that the logic in liquibase/liquibase#4609 is slightly different than in this PR. Let me check if everything has been tested properly in liquibase. Then this PR will need to be changed to reflect the liquibase-core code.

[vitaliimak]

Hi @jgarec
Thank you very much for solving this issue. I appreciate your patience.
The fix in the liquibase core has been tested. I'll merge this PR as is.