fix standardlockservice when changelog-lock-wait-time-in-minutes is set to 0 and lock does not exist in database #4609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipelautert
added
the
SafeToBuild
rberezen
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impact
Description
Fixes #4325
If changelog-lock-wait-time-in-minutes was set to 0 and there was not a lock in the database then acquireLock was not called =>
it was not possible to acquire the lock and the error message was wrong : "Could not acquire change log lock. Currently locked by UNKNOWN"
It's necessary to try at least one time to acquire the lock before waiting (or not if this parameter is set to 0) to retry.
Things to be aware of
Things to worry about
I'm not able to identify if new unit / integration tests are necessary. The current tests are still OK
Additional Context
A PR for liquibase-mongodb is already created : liquibase/liquibase-mongodb#375